[Feature]: Add a field for a secret to the Sink Type #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itionally, it allows developers to create sinks where the authentication is separate from the endpoint
```yaml
apiVersion: core.k8sgpt.ai/v1alpha1
kind: K8sGPT
metadata:
name: k8sgpt
namespace: gpt
spec:
ai:
enabled: true
backend: noopai
sink:
type: telegram
webhook: https://api.telegram.org/bot
secret:
name: telegram-bot-token
key: token
```
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
|
Thanks for the contribution - does it get used anywhere yet? |
|
Although it's not currently in use, I believe it would be beneficial to store the Slack webhook as a secret. We can currently use it for Slack while maintaining backward compatibility. Check if the webhook is configured as a plaintext endpoint or a secret and utilize the appropriate one. I'm unsure whether this should be added to this PR or a separate one. |
|
I think if you added it into this PR it would help show the usecase @phillipahereza |
|
Ahhh shoot, accidentally deleted my fork 🤦. I'll open a new PR later today |
This was referenced Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #309
📑 Description
This change allows developers to configure the sink with secrets.
Additionally, it allows developers to create sinks where the authentication is separate from the endpoint.
✅ Checks
ℹ Additional Information
This PR breaks/affects #303