-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add a field for a secret to the Sink Type #317
Conversation
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @phillipahereza, can you please update Readme to include the new CR spec field and update also the Helm chart's template ?
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a minor fix, thanks again for your contribution :) !
PR is the same as #313 that was accidentally deleted 🤦
Closes #309
📑 Description
This change allows developers to configure the sink with secrets.
Additionally, it allows developers to create sinks where the authentication is separate from the endpoint.
✅ Checks
ℹ Additional Information
This PR breaks/affects #303