Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add a field for a secret to the Sink Type #317

Merged
merged 11 commits into from
Jan 15, 2024
Merged

[Feature]: Add a field for a secret to the Sink Type #317

merged 11 commits into from
Jan 15, 2024

Conversation

phillipahereza
Copy link
Contributor

PR is the same as #313 that was accidentally deleted 🤦

Closes #309

📑 Description

This change allows developers to configure the sink with secrets.
Additionally, it allows developers to create sinks where the authentication is separate from the endpoint.

apiVersion: core.k8sgpt.ai/v1alpha1
kind: K8sGPT
metadata:
  name: k8sgpt
  namespace: gpt
spec:
  ai:
    enabled: true
    backend: openai
  sink:
    type: slack
    secret:
      name: slack-webhook
      key: url

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

This PR breaks/affects #303

@phillipahereza
add secret to sinks
3920d86 
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
@phillipahereza
generate deepcopy
5be9ea3 
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
@phillipahereza
add backward compat for mattermost sink and secret
bf511e3 
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
@phillipahereza phillipahereza marked this pull request as ready for review January 11, 2024 18:28
@phillipahereza phillipahereza requested review from a team as code owners January 11, 2024 18:28
@phillipahereza
sort imports
d85401b 
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
AlexsJones
AlexsJones reviewed Jan 12, 2024
View reviewed changes
pkg/sinks/slack.go Outdated Show resolved Hide resolved
arbreezy
arbreezy previously approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@arbreezy arbreezy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @phillipahereza, can you please update Readme to include the new CR spec field and update also the Helm chart's template ?

@phillipahereza
update readme
aefcc9a 
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
@phillipahereza
Merge branch 'main' into dev
e7a2a9e
@phillipahereza
fix lint
0fbee22 
Signed-off-by: Phillip Ahereza <pahereza@gmail.com>
arbreezy
arbreezy previously approved these changes Jan 15, 2024
View reviewed changes
@arbreezy arbreezy self-requested a review January 15, 2024 22:13
@arbreezy
chore: minor fix in helm's crd
f1b5dab 
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
arbreezy
arbreezy approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a minor fix, thanks again for your contribution :) !

@arbreezy arbreezy merged commit efae4a9 into k8sgpt-ai:main Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones left review comments

@arbreezy arbreezy arbreezy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add a field for a secret to the Sink Type
3 participants
@phillipahereza @AlexsJones @arbreezy