Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Selective Analyzer Execution through Upstream Filtering for Optimized Analysis #146

Closed
2 of 4 tasks
matthisholleville opened this issue Mar 30, 2023 · 3 comments
Closed
2 of 4 tasks

feature: Selective Analyzer Execution through Upstream Filtering for Optimized Analysis #146

matthisholleville opened this issue Mar 30, 2023 · 3 comments
Assignees
@AlexsJones
Labels
enhancement New feature or request

Comments

@matthisholleville
Copy link
Contributor

Checklist:

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature in the #k8sgpt slack channel

Is this feature request related to a problem?

  • Yes
  • No

Describe the solution you'd like

I noticed that when a filter is added during analysis, all analyzers are executed, which makes the analysis very long even if we only want to retrieve the services.

The filter is applied during the merging of errors to display only what the user has indicated in the filter argument. Shouldn't the filter be applied upstream so that only the analyzer we are interested in is executed?

Benefits for the project and its users

Improvement of Performance in Adding Filters
@AlexsJones
Copy link
Member

Yes, this is a great suggestion and as you say would speed things up a lot.. I can change this in a moment

@AlexsJones AlexsJones self-assigned this Mar 30, 2023
@AlexsJones AlexsJones added the enhancement New feature or request label Mar 30, 2023
@AlexsJones
Copy link
Member

Completed in #149

@matthisholleville
Copy link
Contributor Author

Good job @AlexsJones !

fyuan1316 pushed a commit to fyuan1316/k8sgpt that referenced this issue Jun 26, 2023
@renovate
fix(deps): update module github.com/onsi/ginkgo/v2 to v2.10.0 (k8sgpt…
12e0811 
…-ai#146)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexsJones AlexsJones

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexsJones @matthisholleville