Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: analysis speed #149

Merged
merged 3 commits into from
Mar 30, 2023
Merged

feat: analysis speed #149

merged 3 commits into from
Mar 30, 2023

Conversation

AlexsJones
Copy link
Member

Closes #147

πŸ“‘ Description

βœ… Checks

  • [ x] My pull request adheres to the code style of this project
  • [x ] My code requires changes to the documentation
  • I have updated the documentation as required
  • [x ] All the tests have passed

β„Ή Additional Information

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones requested a review from a team as a code owner March 30, 2023 07:20
Copy link
Member

@roberthstrand roberthstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and a local test run seems to work. Good job πŸ‘

@AlexsJones AlexsJones merged commit 3e05eb2 into main Mar 30, 2023
@AlexsJones AlexsJones deleted the feat/analysis-speed branch March 30, 2023 07:44
fyuan1316 pushed a commit to fyuan1316/k8sgpt that referenced this pull request Jun 26, 2023
* feat: generic webhook

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>

* chore: refactoring to catch diff use cases

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>

* feat: decouple emit process and add Result statuses

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>

* feat: add cleanup status process

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>

* chore: minor fix

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>

* fix: conditionals based on latest result object

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>

* fix: missing client Update

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>

* chore: refactor Results creation

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>

* chore: change status sink to webhook

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>

* fix: return from empty result list

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>

---------

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Co-authored-by: Aris Boutselis <arisboutselis08@gmail.com>
Co-authored-by: Alex Jones <alexsimonjones@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants