fix: show trivy as active when activated with --no-install flag #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Kleinlercher <johannes@kleinlercher.at>
Signed-off-by: Thomas Schuetz <38893055+thschue@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #670
📑 Description
when trivy integration is activated with "--no-install" flag, the helm release "trivy-operator-k8sgpt" is not deployed. therefore the check if helm release "trivy-operator-k8sgpt" is deployed is not a valid marker for every use case.
instead of checking for the installed helm release we can check if the api group "aquasecurity.github.io" is available on the K8s cluster and additionally check if at least one trivy filter is in the list of active filters. if we just check for the aquasec api group there is no chance to deactivate the integration again, so we also check for the active filters.
✅ Checks
ℹ Additional Information