Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for vhost-net device mount #181

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Add support for vhost-net device mount #181

merged 1 commit into from
Sep 14, 2021

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Sep 9, 2021

This commit adds support to the sriov-network-operator to request from the sriov-device-plugin to mount the /dev/vhost-net device into the container.

Signed-off-by: Sebastian Sch sebassch@gmail.com

@SchSeba
Copy link
Collaborator Author

SchSeba commented Sep 9, 2021

I had to add the go:build because the go / build CI lane failed.

@SchSeba
Copy link
Collaborator Author

SchSeba commented Sep 9, 2021

@zshi-redhat are you familiar with the CI falling? I try to compile the plugins on my laptop and it pass without any issues

make plugins
go vet ./...
Using version from git...
Building github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/plugins (be86728e)
Using version from git...
Building github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/plugins (be86728e)
Using version from git...
Building github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/plugins (be86728e)
Using version from git...
Building github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/plugins (be86728e)
Using version from git...
Building github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/plugins (be86728e)

I am using go version go1.16 linux/amd64

@zshi-redhat
Copy link
Collaborator

@zshi-redhat are you familiar with the CI falling? I try to compile the plugins on my laptop and it pass without any issues

make plugins
go vet ./...
Using version from git...
Building github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/plugins (be86728e)
Using version from git...
Building github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/plugins (be86728e)
Using version from git...
Building github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/plugins (be86728e)
Using version from git...
Building github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/plugins (be86728e)
Using version from git...
Building github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/plugins (be86728e)

I am using go version go1.16 linux/amd64

It seems an issue with cespare/xxhash pkg + golang-1.17: cespare/xxhash#54
In the CI runs, it uses golang-1.17 even specified as 1.15 in the workflow.
I think we may need to update cespare/xxhash pkg to use latest release v2.1.2.

@SchSeba
Copy link
Collaborator Author

SchSeba commented Sep 12, 2021

waiting for #182

@SchSeba
Add support for vhost-net device mount
6e99f85 
This commit add a support to the sriov-network-operator
to request from the sriov-device-plugin to mount the /dev/vhost-net device into the container.

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@fedepaol
Copy link
Collaborator

/lgtm

@github-actions github-actions bot added the lgtm label Sep 13, 2021
@pliurh pliurh merged commit ac5db51 into k8snetworkplumbingwg:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedepaol fedepaol Awaiting requested review from fedepaol

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

@pliurh pliurh Awaiting requested review from pliurh

Assignees
No one assigned
Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SchSeba @zshi-redhat @fedepaol @pliurh