Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When build with -buildmode=plugin, go complains asm error #54

Closed
MXWXZ opened this issue Aug 18, 2021 · 2 comments
Closed

When build with -buildmode=plugin, go complains asm error #54

MXWXZ opened this issue Aug 18, 2021 · 2 comments

Comments

@MXWXZ
Copy link

MXWXZ commented Aug 18, 2021

When imported and build with -buildmode=plugin or anything use dynamic link, go will throw

when dynamic linking, R15 is clobbered by a global variable access and is used here

ref: review src issue

PR posted, should just replaced with imm-value, seems no other side effect with that.

@cespare
Copy link
Owner

cespare commented Aug 20, 2021

I've started looking at this. I think there are other issues when using dynamic linking, not just R15.

First step is to get the tests running somehow under dynamic linking. This turns out to be fairly annoying (see golang/go#18814, golang/go#18729).

cespare added a commit that referenced this issue Aug 24, 2021
R15 and CX are both clobbered under dynamic linking; avoid them.

Fixes #54
@cespare
Copy link
Owner

cespare commented Aug 24, 2021

I released v2.1.2 with the fix.

AlexanderYastrebov added a commit to zalando/skipper that referenced this issue Aug 24, 2021
Fixes build failure on go 1.17 caused by cespare/xxhash#54

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit to zalando/skipper that referenced this issue Aug 24, 2021
Fixes build failure on go 1.17 caused by cespare/xxhash#54

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit to zalando/skipper that referenced this issue Aug 24, 2021
Fixes build failure on go 1.17 caused by cespare/xxhash#54

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
klauspost added a commit to klauspost/compress that referenced this issue Sep 1, 2021
klauspost added a commit to klauspost/compress that referenced this issue Sep 1, 2021
fedepaol added a commit to fedepaol/sriov-network-operator-1 that referenced this issue Sep 10, 2021
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol added a commit to fedepaol/sriov-network-operator-1 that referenced this issue Sep 10, 2021
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol added a commit to fedepaol/sriov-network-operator-1 that referenced this issue Sep 10, 2021
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol added a commit to fedepaol/sriov-network-operator-1 that referenced this issue Sep 13, 2021
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol added a commit to fedepaol/sriov-network-operator-1 that referenced this issue Sep 13, 2021
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this issue Sep 14, 2021
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/sriov-network-operator that referenced this issue Sep 14, 2021
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
kraj added a commit to kraj/xxhash that referenced this issue Dec 1, 2021
R15 and CX are both clobbered under dynamic linking; avoid them.

Fixes cespare#54

Backport of cespare@e7a6b52

Signed-off-by: Khem Raj <raj.khem@gmail.com>
july2993 added a commit to july2993/freecache that referenced this issue Dec 15, 2021
eh-steve pushed a commit to vivacitylabs/badger that referenced this issue Feb 20, 2022
eh-steve pushed a commit to vivacitylabs/badger that referenced this issue Feb 20, 2022
eh-steve pushed a commit to vivacitylabs/badger that referenced this issue Feb 21, 2022
eh-steve pushed a commit to eh-steve/badger that referenced this issue Apr 4, 2022
eh-steve pushed a commit to eh-steve/badger that referenced this issue Apr 4, 2022
eh-steve added a commit to eh-steve/badger that referenced this issue Apr 5, 2022
eh-steve pushed a commit to eh-steve/badger that referenced this issue Apr 5, 2022
eh-steve added a commit to eh-steve/badger that referenced this issue Apr 5, 2022
jarifibrahim pushed a commit to outcaste-io/badger that referenced this issue Apr 5, 2022
manishrjain pushed a commit to outcaste-io/outserv that referenced this issue Jul 6, 2022
daveamit added a commit to daveamit/health that referenced this issue Jan 6, 2023
geissonator added a commit to geissonator/etcd that referenced this issue Mar 24, 2023
There is a known issue in v2.1.1:

  cespare/xxhash#54

Fix that issue by bumping to the version with the fix.

This has been fixed in upstream etcd via the following:

  etcd-io@f0f77fc

But it was a pretty major upgrade so just take the one piece we need for
the etcd v3.5 release tag.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
geissonator added a commit to geissonator/etcd that referenced this issue Mar 24, 2023
There is a known issue in v2.1.1:

  cespare/xxhash#54

Fix that issue by bumping to the version with the fix.

This has been fixed in upstream etcd via the following:

  etcd-io@f0f77fc

But it was a pretty major upgrade so just take the one piece we need for
the etcd v3.5 release tag.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
mangalaman93 pushed a commit to dgraph-io/ristretto that referenced this issue Dec 11, 2023
When using ristretto in a Go plugin it's currently failing to build due
to: cespare/xxhash#54, so this PR is simply
updating the dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants