Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue in
krakend-ce
: krakend/krakend-ce#439 (comment)I have been running into issues when trying to upgrade to KrakenD v2 that appear to be related to
krakend-opencensus
. When trying to build a custom plugin, I run into the following error:# github.com/cespare/xxhash/v2 asm: xxhash_amd64.s:120: when dynamic linking, R15 is clobbered by a global variable access and is used here: 00092 (/go/pkg/mod/github.com/cespare/xxhash/v2@v2.1.1/xxhash_amd64.s:120) ADDQ R15, AX asm: assembly failed
The above error has been fixed in
github.com/cespare/xxhash/v2 v2.1.2
(cespare/xxhash#54), but the version ofgit.luolix.top/prometheus/client_golang
used in this project is usinggit.luolix.top/cespare/xxhash/v2 v2.1.1
. The xxhash dependency was updated in prometheus/client_golang#913 (v1.12.0).NOTE: Additional dependencies were updated in this PR. I believe this is just a result of updated transitive dependencies. I'm still pretty new to Go and the module dependency system, so please let me know if this needs to be fixed. I just updated the version of
github.com/prometheus/client_golang
in go.mod and rango mod tidy
.