Resumable newblock in mining #1891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundnoble
changed the title
edmundnoble
force-pushed
the
I25e1ab240e4522d7e56812ff170d0aa849125abe
branch
from
a2e1f2a
to
1bda787
Compare
This change makes readFrom return Nothing when the target parent is missing. Test plan: just our existing tests. Change-Id: I67fd68ed09707c9bff00b0cf7906e026974a2343
This adds a new pact request called ContinueBlock to do this resumption and also adds an option to NewBlock which allows creating empty blocks; as well, the state involved in blocks in progress is encapsulated in a new BlockInProgress type. Test plan is a new test that checks that a block created via NewBlock is identical to a block created via a combination of NewBlock and ContinueBlock. Change-Id: Id0e6f9ac29cbef4e1b029db5be7aee0b80c2f9c8
Makes the mining loop use ContinueBlock to periodically "refresh" blocks, ensuring that they use all of the transactions in the mempool if possible. Test plan will be to put this on a testnet mining node. Change-Id: I25e1ab240e4522d7e56812ff170d0aa849125abe
edmundnoble
force-pushed
the
I25e1ab240e4522d7e56812ff170d0aa849125abe
branch
from
1bda787
to
1ba9af8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the mining loop use ContinueBlock to periodically "refresh" blocks,
ensuring that they use all of the transactions in the mempool if possible.
Test plan will be to put this on a testnet mining node.
https://gerrit.aseipp.dev/q/I25e1ab240e4522d7e56812ff170d0aa849125abe