Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resumable newblock in mining #1891

Closed
wants to merge 3 commits into from
Closed

Resumable newblock in mining #1891

wants to merge 3 commits into from

Commits on Apr 5, 2024

  1. refactor: readFrom returns Nothing when parent is missing 

    This change makes readFrom return Nothing when the target parent is missing.

Test plan: just our existing tests. 


Change-Id: I67fd68ed09707c9bff00b0cf7906e026974a2343
    @edmundnoble
    edmundnoble committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    56eb653 View commit details
    Browse the repository at this point in the history

  2. feature: newblock resumes blocks in progress 

    This adds a new pact request called ContinueBlock to do this resumption
and also adds an option to NewBlock which allows creating empty blocks;
as well, the state involved in blocks in progress is encapsulated in a 
new BlockInProgress type.

Test plan is a new test that checks that a block created via NewBlock
is identical to a block created via a combination of NewBlock and
ContinueBlock.

Change-Id: Id0e6f9ac29cbef4e1b029db5be7aee0b80c2f9c8
    @edmundnoble
    edmundnoble committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    50f59b3 View commit details
    Browse the repository at this point in the history

  3. feature: miner continues blocks periodically 

    Makes the mining loop use ContinueBlock to periodically "refresh" blocks,
ensuring that they use all of the transactions in the mempool if possible.

Test plan will be to put this on a testnet mining node.

Change-Id: I25e1ab240e4522d7e56812ff170d0aa849125abe
    @edmundnoble
    edmundnoble committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1ba9af8 View commit details
    Browse the repository at this point in the history