Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix captoken codec, add SigCapability, move Signer to its own module #210

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jmcardon
Copy link
Member

@jmcardon jmcardon commented Aug 30, 2024

This PR moves Signer into its own module, as it isn't really used outside of the chainweb and request API.

Moreover: I am adding a SigCapability newtype, that essentially has a fixed json codec for the sake of both chainweb, as well as testing.

The changes here are mostly a refactoring, so it's covered by previous tests for signers. That said: in fixing the codec of ModuleGuard, I realize we definitely need a golden test for stable encoding. This will be done by @rsoeldner

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
    Doesn't impact perf
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

@jmcardon jmcardon marked this pull request as ready for review August 30, 2024 20:16
@jmcardon jmcardon merged commit 72d1ebf into master Sep 5, 2024
12 checks passed
@jmcardon jmcardon deleted the jose/fix-codec branch September 5, 2024 16:32
@rsoeldner
Copy link
Member

We approved in a call, forgot to approve it on GH.

@jmcardon jmcardon mentioned this pull request Sep 6, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants