Fix captoken codec, add SigCapability, move Signer to its own module #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
Signer
into its own module, as it isn't really used outside of the chainweb and request API.Moreover: I am adding a
SigCapability
newtype, that essentially has a fixed json codec for the sake of both chainweb, as well as testing.The changes here are mostly a refactoring, so it's covered by previous tests for signers. That said: in fixing the codec of
ModuleGuard
, I realize we definitely need a golden test for stable encoding. This will be done by @rsoeldnerPR checklist:
Additionally, please justify why you should or should not do the following:
Doesn't impact perf