Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration: Fix verifier codec #217

Merged
merged 12 commits into from
Sep 11, 2024
Merged

Integration: Fix verifier codec #217

merged 12 commits into from
Sep 11, 2024

Conversation

jmcardon
Copy link
Member

@jmcardon jmcardon commented Sep 6, 2024

#210 unintentionally broke a codec chainweb depends on. This PR fixes the signer codec + adds roundtrip tests + a regression for ensuring pact-5 can deserialize prod values.

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

@jmcardon jmcardon changed the title Fix verifier codec Integration: Fix verifier codec Sep 9, 2024
@jmcardon jmcardon marked this pull request as ready for review September 9, 2024 23:48
@jmcardon
Copy link
Member Author

jmcardon commented Sep 9, 2024

Note: This PR is blocked on making CI pass. We need to ensure that we have the regression sqlite file cached in the runners somehow

@jmcardon jmcardon merged commit b5e3dae into master Sep 11, 2024
3 checks passed
@jmcardon jmcardon deleted the jose/fix-signer-codec branch September 11, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants