-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration: Fix verifier codec #217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcardon
force-pushed
the
jose/fix-signer-codec
branch
from
September 9, 2024 23:46
b313037
to
77cf66a
Compare
Note: This PR is blocked on making CI pass. We need to ensure that we have the regression sqlite file cached in the runners somehow |
jmcardon
force-pushed
the
jose/fix-signer-codec
branch
from
September 10, 2024 02:09
21a5a11
to
d8dffe1
Compare
jmcardon
force-pushed
the
jose/fix-signer-codec
branch
from
September 10, 2024 02:29
d8dffe1
to
46eab59
Compare
yeah I thought so
June/verify download of chain9
rsoeldner
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#210 unintentionally broke a codec chainweb depends on. This PR fixes the signer codec + adds roundtrip tests + a regression for ensuring pact-5 can deserialize prod values.
PR checklist:
Additionally, please justify why you should or should not do the following: