FE: Fix Default Consumer's Lag Value

[K-Diger]

• Breaking change? (if so, please describe the impact and migration path for existing application instances)

close #675

The default value of Consumer Lag displayed when searching the Consumer List has been modified.

The existing displayed value is 'N/A', which is different from the response value of '0' that the server responds to.

We believe that 'N/A' may mean a state of disuse, so we write it as 0 to make it clear.

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

• No need to
• Manually (please, describe, if necessary)
• Unit checks
• Integration checks
• Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
• My changes generate no new warnings (e.g. Sonar is happy)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

[github-actions]

Hi K-Diger! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

[Haarolean]

N/A and 0 values for this field are two distinct things, please see provectus/kafka-ui#3728 for more details. Unless you can provide additional information on why we should treat both the same, I doubt we need these changes. Let me know what you think.

[kapybro]

Further user feedback is requested. Please reply within 7 days or we might close the issue.

[K-Diger]

@Haarolean

N/A and 0 values for this field are two distinct things, please see provectus/kafka-ui#3728 for more details. Unless you can provide additional information on why we should treat both the same, I doubt we need these changes. Let me know what you think.

Since the server responds with exactly 0, I think this is different from the situation where it displays 'N/A' for the issue you tagged.

{
    "pageCount": 1,
    "consumerGroups": [
        {
            "inherit": "ConsumerGroupDTO",
            "groupId": "connect-secom-alarm-sink-connector",
            "members": 1,
            "topics": 1,
            "simple": false,
            "partitionAssignor": "range",
            "state": "STABLE",
            "coordinator": {
                "id": 1,
                "host": "�localhost",
                "port": 29092,
                "bytesInPerSec": null,
                "bytesOutPerSec": null,
                "partitionsLeader": null,
                "partitions": null,
                "inSyncPartitions": null,
                "partitionsSkew": null,
                "leadersSkew": null
            },
            "consumerLag": 0
        }
    ]
}

The value displayed in the JSON response above is the same as the photo I attached.

In conclusion, the tagged issue appears to be a proposal to indicate N/A when data cannot be loaded.

What I am suggesting is to not represent 0 as 'N/A'.

Also /ui/clusters/kafka_cluster/consumer-groups/{consumer-group-name}

In the URL above, the receiving consumer LAG will receive something labeling 0 if it receives 0 from the server.

{
    "inherit": "details",
    "groupId": "connect-secom-alarm-sink-connector",
    "members": 1,
    "topics": 1,
    "simple": false,
    "partitionAssignor": "range",
    "state": "STABLE",
    "coordinator": {
        "id": 2,
        "host": "localhost",
        "port": 29092,
        "bytesInPerSec": null,
        "bytesOutPerSec": null,
        "partitionsLeader": null,
        "partitions": null,
        "inSyncPartitions": null,
        "partitionsSkew": null,
        "leadersSkew": null
    },
    "consumerLag": 0,
    "partitions": [
        {
            "topic": "tlm.v1.secom-alarm",
            "partition": 0,
            "currentOffset": 33682842,
            "endOffset": 33682842,
            "consumerLag": 0,
            "consumerId": "connector-consumer-secom-alarm-sink-connector-0-eb96be4f-dcdf-47c4-8267-f0505116c6e9",
            "host": "localhost"
        }
    ]
}

[kapybro]

Thanks for the additional feedback! We'll get back to your issue soon.

[Haarolean]

Since the server responds with exactly 0, I think this is different from the situation where it displays 'N/A' for the issue you tagged.

In this case, I don't think your changes make sense.
The lag is 0 in your response ("consumerLag": 0), which, under current implementation, (return args.getValue() || 'N/A';) will be displayed as is. args.getValue() would be false only in case of undefined, not 0. Am I missing something here?

[K-Diger]

In this case, I don't think your changes make sense. The lag is 0 in your response ("consumerLag": 0), which, under current implementation, (return args.getValue() || 'N/A';) will be displayed as is. args.getValue() would be false only in case of undefined, not 0. Am I missing something here?

I've revised the code again based on your feedback.

This time, the modified code displays the response as 0 only when it is 0.

I modified it to display 'N/A' when the value cannot actually be retrieved, such as null.

[K-Diger]

Thanks for your reply. We have made a commit that reflects your feedback, so please check. 2024년 12월 19일 (목) 오전 12:56, Roman Zabaluev ***@***.***>님이 작성:

…

Since the server responds with exactly 0, I think this is different from the situation where it displays 'N/A' for the issue you tagged. In this case, I don't think your changes make sense. The lag is 0 in your response ("consumerLag": 0), which, under current implementation, (return args.getValue() || 'N/A';) will be displayed as is. args.getValue() would be false only in case of undefined, not 0. Am I missing something here? — Reply to this email directly, view it on GitHub <#686 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOOCHT4TOJS6HQDIHDTA6BD2GGLMXAVCNFSM6AAAAABSYF2N3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJRGY4TONZWGY> . You are receiving this because you were assigned.Message ID: ***@***.***>

[K-Diger]

I've added my comments on what you said and a commit for additional test code. We would appreciate it if you could give us feedback after checking.