Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: toString() missing in KsqlArtefact subclasses #289

Closed
schocco opened this issue May 31, 2021 · 1 comment · Fixed by #308
Closed

Minor: toString() missing in KsqlArtefact subclasses #289

schocco opened this issue May 31, 2021 · 1 comment · Fixed by #308
Labels
bug Something isn't working

Comments

@schocco
Copy link
Contributor

schocco commented May 31, 2021

Describe the bug
The console output com.purbon.kafka.topology.KSqlArtefactManager#printCurrentState does currently list streams and tables with the default object string implementation.

To Reproduce
add KSQL artefacts to the plan and run

Expected behavior
name of the string and serverlabel (if not null) should be shown

Runtime (please complete the following information):

  • OS: Windows
  • JVM version: openjdk 11
  • Version 73c18ea
@schocco schocco added the bug Something isn't working label May 31, 2021
schocco pushed a commit to schocco/julie that referenced this issue Jun 1, 2021
add missing toString method
d89be29 
kafka-ops#289
@schocco schocco mentioned this issue Jun 2, 2021
Closed
4 tasks
schocco pushed a commit to schocco/julie that referenced this issue Jun 4, 2021
fix tests for toString()
a66bab6 
kafka-ops#289
schocco pushed a commit to schocco/julie that referenced this issue Jun 15, 2021
extend ksql support
ad4df83 
* add documentation for new ksql properties and introduce KsqlClientConfig class to bundle ksql related options
    format code
* add wait strategy in to ksql container to get rid of Thread.sleep call in integration tests
* add basic support for TLS and fix handling ksql urls kafka-ops#288 kafka-ops#287
* add missing toString method  kafka-ops#289
@schocco schocco mentioned this issue Aug 2, 2021
Merged
purbon added a commit that referenced this issue Sep 11, 2021
@schocco @purbon
Ksql: Add SSL support and bugfixes (#308)
6bf0280 
* extend ksql support

* add documentation for new ksql properties and introduce KsqlClientConfig class to bundle ksql related options
    format code
* add wait strategy in to ksql container to get rid of Thread.sleep call in integration tests
* add basic support for TLS and fix handling ksql urls #288 #287
* add missing toString method  #289

* refactor and add tests

* ensure verifyHost defaults to true
* testcontainers: wait for log message instead of polling ksql /info endpoint
* refactor to use BasicAuth class in JulieHttpClient
* add integration test for ksqldb with TLS

* remove editorconfig

* ammend token variable initialization within the julie http base client

Co-authored-by: Rocco Schulz <rocco@is-gr8.com>
Co-authored-by: Pere Urbón <purbon@users.noreply.github.com>
Co-authored-by: Pere Urbon <pere@confluent.io>
@purbon
Copy link
Collaborator

purbon commented Sep 11, 2021

closed with the merge of #308

@purbon purbon closed this as completed Sep 11, 2021
@purbon purbon linked a pull request Sep 11, 2021 that will close this issue
Ksql: SSL support, bugfixes #308
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ksql: SSL support, bugfixes schocco/julie
2 participants
@purbon @schocco