Ksql: SSL support, bugfixes #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schocco
commented
Aug 2, 2021
schocco
commented
- Please check if the PR fulfills these requirements
- [ x] The commit messages are descriptive
- [ x] Tests for the changes have been added (for bug fixes / features)
- [ x] Docs have been added / updated (for bug fixes / features)
- [ x] An issue has been created for the pull requests. Some issues might require previous discussion.
- What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
- bug fix for URL handling in ksql settings (Minor glitch regarding KSQL configuration Minor glitch regarding KSQL configuration #288)
- support for security https urls (implements Security Support for KSQL Security Support for KSQL #287)
- adds missing toString methods for ksql artefacts (Minor: toString() missing in KsqlArtefact subclasses Minor: toString() missing in KsqlArtefact subclasses #289 )
* add documentation for new ksql properties and introduce KsqlClientConfig class to bundle ksql related options
format code
* add wait strategy in to ksql container to get rid of Thread.sleep call in integration tests
* add basic support for TLS and fix handling ksql urls kafka-ops#288 kafka-ops#287
* add missing toString method kafka-ops#289
* ensure verifyHost defaults to true * testcontainers: wait for log message instead of polling ksql /info endpoint * refactor to use BasicAuth class in JulieHttpClient * add integration test for ksqldb with TLS
|
Hi @schocco thanks a lot for your contribution, I would really love to see it in, sorry for the long hiatus here, time has not certainly help lately between family, work and pandemic. |
|
Hi @schocco, I took some time this morning to go over your PR, thanks a lot for your contribution. As the integration test where failing, I am going to manually squash and merge it, thanks for your contribution again and apologies for the long hiatus, family, work and pandemic takes a toll |
purbon
approved these changes
Sep 11, 2021
This was referenced Sep 11, 2021
This was
linked to
issues
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.