Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading of old-style state files #315

Merged
merged 4 commits into from
Sep 10, 2021

Conversation

sverrehu
Copy link
Contributor

@sverrehu sverrehu commented Sep 8, 2021

  • Please check if the PR fulfills these requirements
  • The commit messages are descriptive
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • An issue has been created for the pull requests. Some issues might require previous discussion.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Backwards compatibility.

  • What is the current behavior? (You can also link to an open issue here)

After switching to JSON for state files, old-style state files make JulieOps crash.

  • What is the new behavior (if this is a feature change)?

If the first line read from the state file matches one of the tags from the old format, a simplified helper class is used for reading the file.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

I hope not.

@purbon purbon self-requested a review September 9, 2021 14:46
@sverrehu sverrehu mentioned this pull request Sep 10, 2021
4 tasks
@purbon
Copy link
Collaborator

purbon commented Sep 10, 2021

Hi @sverrehu thanks a lot for your contribution. I was thinking to break compatibility with 3.0, but is always better to have it backwards compatible ;-) thanks a lot for the effort and time.

Copy link
Collaborator

@purbon purbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as always good job! thanks a lot again!

@purbon purbon merged commit f902393 into kafka-ops:master Sep 10, 2021
@sverrehu sverrehu deleted the file-backend-backward-compat branch March 22, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants