-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FileBackend VCS diff friendly #317
Make FileBackend VCS diff friendly #317
Conversation
I guess the failing test is a transient failure. Integration tests (-Pacls) run fine on my Mac and on my Linux. |
@sverrehu I merged the other PR and now this needs rebase. Not sure about the test, I will test as well once conflicts are fixed. thanks a lot again for your help and steady contributions, I am personally sad I can't keep up due to family and work. Thanks again |
so yes, test was transient failure ;-) |
more fix on the release legacy job more identity fix
I tried to fix, but there are unrelated changes in my PR, so I failed. Closing for now. My git-foo is not as strong as my Java-foo. |
Re "I am personally sad I can't keep up due to family and work"... Yes, I have been there. I'm probably 20 years ahead, and both my kids have moved out. Would like to send you a PM, if I figured out how to do it. shh+github@thathost.com |
Increase CI/CD-friendlyness for FileBackend state files. Recent introduction of JSON for state files in JulieOps made it harder to track state changes in git, since the entire JSON was stored as a single line. This patch will pretty-print the JSON text, in order to better be able to track what has changed.
NOTE: This patch is built on top of my previous, unmerged PR.
.cluster-state is a single line of JSON, so when committing to git, it is impossible (or at least cumbersome) to se what has changed.
.cluster-state is a pretty-printed, multi-line JSON file.
I don't think so.