Fix config passing for topology validator for regular expressions #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purbon
added a commit
that referenced
this pull request
Feb 5, 2022
* fix config passing for topology validator for regular expressions * ammend docs
|
Hi, Pere! This introduced a breaking change. Our no-arg validators are no longer loaded, and have to be rewritten. |
|
auch, sorry for that, I missed this. How can I help with that? do you have an example of these validators, so I can fix it for you guys? |
|
I'll prepare a PR, if that is OK with you. |
|
that would be very lovely! thanks a lot!!
…On Thu, Apr 7, 2022 at 11:09 AM Sverre H. Huseby ***@***.***> wrote:
I'll prepare a PR, if that is OK with you.
—
Reply to this email directly, view it on GitHub
<#443 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAQXPCV2F4OCD6LJ5EZKULVD2Q4XANCNFSM5MYV4ZCQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
--
Pere Urbon-Bayes
Software Architect
https://twitter.com/purbon
https://www.linkedin.com/in/purbon/
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #442