-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validators backwards compatibility #480
Merged
purbon
merged 2 commits into
kafka-ops:master
from
sverrehu:add-validators-backwards-compatibility
Apr 7, 2022
Merged
Add validators backwards compatibility #480
purbon
merged 2 commits into
kafka-ops:master
from
sverrehu:add-validators-backwards-compatibility
Apr 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With just the first commit, which removes the |
LGTM, merging as soon as test are passing. |
Thanks! Will there be a 4.1.3 release with this? |
doing one tomorrow morning first thing, sorry slammed with work today.
…On Thu, Apr 7, 2022 at 2:47 PM Sverre H. Huseby ***@***.***> wrote:
Thanks! Will there be a 4.1.3 release with this?
—
Reply to this email directly, view it on GitHub
<#480 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAQXPCLZSLQ4O66XBHBFK3VD3KMVANCNFSM5SYZC3MA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
--
Pere Urbon-Bayes
Software Architect
https://twitter.com/purbon
https://www.linkedin.com/in/purbon/
|
In the meanwhile, you have
https://github.com/kafka-ops/julie/actions/runs/2108865274 latest build.
…-- Pere
On Thu, Apr 7, 2022 at 2:53 PM Pere Urbón Bayes ***@***.***>
wrote:
doing one tomorrow morning first thing, sorry slammed with work today.
On Thu, Apr 7, 2022 at 2:47 PM Sverre H. Huseby ***@***.***>
wrote:
> Thanks! Will there be a 4.1.3 release with this?
>
> —
> Reply to this email directly, view it on GitHub
> <#480 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAQXPCLZSLQ4O66XBHBFK3VD3KMVANCNFSM5SYZC3MA>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
--
Pere Urbon-Bayes
Software Architect
https://twitter.com/purbon
https://www.linkedin.com/in/purbon/
--
Pere Urbon-Bayes
Software Architect
https://twitter.com/purbon
https://www.linkedin.com/in/purbon/
|
purbon
pushed a commit
that referenced
this pull request
Apr 8, 2022
* Make some validators old fashioned * Support pre 4.1.1 validators with no-arg constructors
@sverrehu https://github.com/kafka-ops/julie/releases/tag/v4.1.3 fyi 👍 , have a nice weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert backwards compatibility break introduced in #443
Validators with just no-arg constructors fail to load.
Validators with just no-arg constructors will load again, if no Configuration constructor is found.
Hopefully not.