Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validators backwards compatibility #480

Merged

Conversation

sverrehu
Copy link
Contributor

@sverrehu sverrehu commented Apr 7, 2022

  • Please check if the PR fulfills these requirements
  • [x ] The commit messages are descriptive
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • An issue has been created for the pull requests. Some issues might require previous discussion.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Revert backwards compatibility break introduced in #443

  • What is the current behavior? (You can also link to an open issue here)

Validators with just no-arg constructors fail to load.

  • What is the new behavior (if this is a feature change)?

Validators with just no-arg constructors will load again, if no Configuration constructor is found.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Hopefully not.

  • Other information:

@sverrehu
Copy link
Contributor Author

sverrehu commented Apr 7, 2022

With just the first commit, which removes the Configuration constructor from some validator classes, tests in TopologyValidationTest fail with NoSuchMethodException. With the second commit added, these tests work again.

@purbon
Copy link
Collaborator

purbon commented Apr 7, 2022

LGTM, merging as soon as test are passing.

@purbon purbon merged commit f6fe353 into kafka-ops:master Apr 7, 2022
@sverrehu
Copy link
Contributor Author

sverrehu commented Apr 7, 2022

Thanks! Will there be a 4.1.3 release with this?

@purbon
Copy link
Collaborator

purbon commented Apr 7, 2022 via email

@purbon
Copy link
Collaborator

purbon commented Apr 7, 2022 via email

purbon pushed a commit that referenced this pull request Apr 8, 2022
* Make some validators old fashioned

* Support pre 4.1.1 validators with no-arg constructors
@purbon
Copy link
Collaborator

purbon commented Apr 8, 2022

@sverrehu https://github.com/kafka-ops/julie/releases/tag/v4.1.3 fyi 👍 , have a nice weekend!

@sverrehu sverrehu deleted the add-validators-backwards-compatibility branch March 22, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants