Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we pulled up the
equals
method to theMoney
class and resorted all the comparisons againstMoney
object, we've created an unintended side effect: nowDollar
andFranc
objects are considered equal. This PR fixes this problem by comparingobject.constructor.name
to the currentthis.constructor.name
, which is basically using a (dirty) resource from the programming language to fix a domain problem, that's why we've added "Currency?" to the bottom of the task list:.equals
✅.times