Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix franc dollar comparison #7

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Fix franc dollar comparison #7

merged 2 commits into from
Sep 28, 2022

Commits on Sep 28, 2022

  1. introduce test to prove that Francs are being considered equal Dollars 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private ✅
- Dollar side-effects? ✅
- Money rounding?
- equals() ✅
- Equal null
- Equal object
- 5 CHF * 2 = 10 CHF ✅
- Dollar/Franc duplication
- Common `.equals` ✅
- Common `.times`
- Compare Francs with Dollars 👈🏼
    @kaiosilveira
    kaiosilveira committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    0527e8b View commit details
    Browse the repository at this point in the history

  2. check instance class name when checking equality at Money.equals 

    Tasklist:
- $5 + 10CHF = $10 if rate is 2:1 🎯
- $5 * 2 = $10 ✅
- Make "amount" private ✅
- Dollar side-effects? ✅
- Money rounding?
- equals() ✅
- Equal null
- Equal object
- 5 CHF * 2 = 10 CHF ✅
- Dollar/Franc duplication
- Common `.equals` ✅
- Common `.times`
- Compare Francs with Dollars ✅
- Currency?
    @kaiosilveira
    kaiosilveira committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    2d6e1bf View commit details
    Browse the repository at this point in the history