feat(varlogtest): create new instance of admin and log

[ijsong]

What this PR does

This PR renames pkg/varlogtest.(*VarlogTest).Admin and pkg/varlogtest.(*VarlogTest).Log to pkg/varlogtest.(*VarlogTest).NewAdminClient and pkg/varlogtest.(*VarlogTest).NewLogClient respectively. It also makes them return a new instance of the admin client and the log client when invoked.
Previously, they returned the same instances, so callers shared them. However, it wasn't the right decision because the callers had to share the clients regardless of their needs.

[ijsong]

Current dependencies on/for this PR:

• main
  • PR build(go): use go 1.21 #585
    • PR ci(lint): use specific version for golaingci-lint rather than latest #586
      • PR fix(admin): refresh cluster metadata while adding storage node #558
        • PR test(e2e): use zaptest logger #557
          • PR feat(all): add gogoproto codec to grpc servers #581
            • PR refactor: add the standard flag --replication-factor #553
              • PR feat(all): change type of ClusterID from uint32 to int32 #566
                • PR refactor(all): make cluster id flag common #567
                  • PR feat(varlogtest): add functional options to varlogtest #582
                  • PR feat(varlogtest): add initial metadata repository and support fetch APIs #583
                  • PR feat(varlogtest): create new instance of admin and log #591 👈
                  • PR fix(varlogtest): validate log stream descriptor to create it #593
                  • PR fix(varlogtest): log stream appender returns missing errors in the callback #594
                  • PR fix(varlogtest): log stream appender can be closed in the callback #595
              • PR refactor(admin): prevent the large lock from mrmanager #554
                • PR feat(admin): check cluster id in mrmanager #555
                  • PR feat(admin): check replication factor in mrmanager #556
                  • PR refactor(admin): prevent large lock from internal/admin.(*Admin) #559

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c033d62) 61.28% compared to head (2c98f7f) 61.19%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                       Coverage Diff                       @@
##           varlogtest_initial_mr_nodes     #591      +/-   ##
===============================================================
- Coverage                        61.28%   61.19%   -0.09%     
===============================================================
  Files                              144      144              
  Lines                            19184    19182       -2     
===============================================================
- Hits                             11757    11739      -18     
- Misses                            6841     6858      +17     
+ Partials                           586      585       -1     

Files	Coverage Δ
pkg/varlogtest/varlogtest.go	90.32% <100.00%> (-0.21%)	⬇️
pkg/varlogtest/admin.go	45.32% <50.00%> (ø)
pkg/varlogtest/log.go	71.64% <66.66%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ijsong]

Merge Activity

• Oct 4, 3:30 AM: @ijsong started a stack merge that includes this pull request via Graphite.
• Oct 4, 3:32 AM: @ijsong merged this pull request with Graphite.