refactor: add the standard flag --replication-factor

[ijsong]

What this PR does

Previously varlogadm and varlogmr defined the flag for replication factor, respectively, which made strings for the flag different.
This change adds a new standard flag, --replication-factor. It also sets the type of replication factor to an integer.

[ijsong]

Current dependencies on/for this PR:

• main
  • PR build(go): use go 1.21 #585
    • PR ci(lint): use specific version for golaingci-lint rather than latest #586
      • PR fix(admin): refresh cluster metadata while adding storage node #558
        • PR test(e2e): use zaptest logger #557
          • PR feat(all): add gogoproto codec to grpc servers #581
            • PR refactor: add the standard flag --replication-factor #553 👈
              • PR feat(all): change type of ClusterID from uint32 to int32 #566
                • PR refactor(all): make cluster id flag common #567
                  • PR feat(varlogtest): add functional options to varlogtest #582
                  • PR feat(varlogtest): add initial metadata repository and support fetch APIs #583
                  • PR feat(varlogtest): create new instance of admin and log #591
                  • PR fix(varlogtest): validate log stream descriptor to create it #593
                  • PR fix(varlogtest): log stream appender returns missing errors in the callback #594
                  • PR fix(varlogtest): log stream appender can be closed in the callback #595
              • PR refactor(admin): prevent the large lock from mrmanager #554
                • PR feat(admin): check cluster id in mrmanager #555
                  • PR feat(admin): check replication factor in mrmanager #556
                  • PR refactor(admin): prevent large lock from internal/admin.(*Admin) #559

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (grpc_server_codec@5e1f344). Click here to learn what that means.
Patch coverage: 88.88% of modified lines in pull request are covered.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                 Coverage Diff                  @@
##             grpc_server_codec     #553   +/-   ##
====================================================
  Coverage                     ?   61.10%           
====================================================
  Files                        ?      143           
  Lines                        ?    19081           
  Branches                     ?        0           
====================================================
  Hits                         ?    11660           
  Misses                       ?     6841           
  Partials                     ?      580           

Files Changed	Coverage Δ
internal/metarepos/config.go	67.30% <ø> (ø)
internal/admin/admin.go	61.58% <50.00%> (ø)
internal/admin/config.go	85.85% <100.00%> (ø)
internal/flags/cluster.go	100.00% <100.00%> (ø)
tests/it/testenv.go	34.54% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ijsong]

Merge Activity

• Oct 4, 3:30 AM: @ijsong started a stack merge that includes this pull request via Graphite.
• Oct 4, 3:32 AM: @ijsong merged this pull request with Graphite.