refactor(admin): prevent the large lock from mrmanager #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijsong
force-pushed
the
common_repfactor_from_uint_to_int
branch
from
6702ac2 to
fd9e4d7
Compare
This was referenced Jul 31, 2023
This was referenced Aug 21, 2023
ijsong
force-pushed
the
common_repfactor_from_uint_to_int
branch
from
fd9e4d7 to
6a9eb6f
Compare
This was referenced Sep 11, 2023
ijsong
force-pushed
the
common_repfactor_from_uint_to_int
branch
from
6a9eb6f to
833c9aa
Compare
This was referenced Sep 11, 2023
Merged
ijsong
force-pushed
the
mr_no_large_lock
branch
from
59cbb21 to
b3f894d
Compare
This was referenced Sep 11, 2023
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 61.20% 61.12% -0.09%
==========================================
Files 144 144
Lines 19241 19241
==========================================
- Hits 11777 11761 -16
- Misses 6876 6888 +12
- Partials 588 592 +4 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
common_repfactor_from_uint_to_int
branch
from
833c9aa to
b032afa
Compare
This was referenced Sep 25, 2023
ijsong
force-pushed
the
common_repfactor_from_uint_to_int
branch
from
b032afa to
4b505b6
Compare
This was referenced Sep 27, 2023
This PR changes the role of `internal/admin/mrmanager.(*mrManager).mu`. The large lock in the mrmanager made the mrmanager run sequentially. However, from now, it only guards the dirty flag for the cluster metadata. Since the metadata repository works concurrently, adopting a large lock on the client side is unnecessary.
ijsong
force-pushed
the
mr_no_large_lock
branch
from
b3f894d to
efe2d44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR changes the role of
internal/admin/mrmanager.(*mrManager).mu. The large lock in the mrmanager made the mrmanager run sequentially. However, from now, it only guards the dirty flag for the cluster metadata. Since the metadata repository works concurrently, adopting a large lock on the client side is unnecessary.