Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage,storagenode): remove unnecessary codes related to legacy commit context #292

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Dec 21, 2022

What this PR does

This patch removes unnecessary codes related to legacy commit context and
finalizes the
RFC
.

Which issue(s) this PR resolves

Updates #149

@ijsong ijsong marked this pull request as ready for review December 21, 2022 09:09
@ijsong ijsong requested a review from hungryjang as a code owner December 21, 2022 09:09
@ijsong ijsong self-assigned this Dec 21, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 63.15% // Head: 63.10% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (d8f736f) compared to base (c3066b8).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
- Coverage   63.15%   63.10%   -0.06%     
==========================================
  Files         130      130              
  Lines       17357    17308      -49     
==========================================
- Hits        10962    10922      -40     
+ Misses       5841     5834       -7     
+ Partials      554      552       -2     
Impacted Files Coverage Δ
internal/storage/encode.go 96.72% <ø> (-1.34%) ⬇️
internal/storage/recovery_points.go 90.69% <63.63%> (-5.23%) ⬇️
internal/storage/commit_batch.go 100.00% <100.00%> (ø)
internal/storagenode/replication_server.go 76.27% <0.00%> (-2.55%) ⬇️
internal/metarepos/raft_metadata_repository.go 76.48% <0.00%> (-0.18%) ⬇️
internal/metarepos/report_collector.go 77.42% <0.00%> (+0.42%) ⬆️
internal/metarepos/storage.go 79.22% <0.00%> (+0.53%) ⬆️
internal/storagenode/logstream/executor.go 81.48% <0.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@hungryjang hungryjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good bye cc

@ijsong ijsong merged commit 0a167a2 into kakao:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants