-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: draft on improving commit context #149
Conversation
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 62.86% 62.93% +0.07%
==========================================
Files 126 126
Lines 17049 17049
==========================================
+ Hits 10718 10730 +12
+ Misses 5781 5773 -8
+ Partials 550 546 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
docs/RFCs/20220915_commit_context.md
Outdated
|
||
A large amount of empty commit contexts not only causes too slow recovery of | ||
log streams but also takes a quite large disk space. To solve these problems, | ||
this RFC proposes to store only the latest non-empty commit context rather |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need latest commit context & latest non-empty commit context both.
Latest commit context is used for valid report version to trim commit result in metadata repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right. I'll fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hungryjang
Modified the draft to store the latest commit context regardless of emptiness.
dc5f15e
to
75ac227
Compare
75ac227
to
84047c5
Compare
@hungryjang |
What this PR does
RFC draft on improving commit context
Which issue(s) this PR resolves
Ref: #125
Anything else
This change is