Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: draft on improving commit context #149

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Sep 15, 2022

What this PR does

RFC draft on improving commit context

Which issue(s) this PR resolves

Ref: #125

Anything else


This change is Reviewable

@ijsong ijsong requested a review from hungryjang September 15, 2022 14:15
@ijsong ijsong self-assigned this Sep 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #149 (dc5f15e) into main (1340bba) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   62.86%   62.93%   +0.07%     
==========================================
  Files         126      126              
  Lines       17049    17049              
==========================================
+ Hits        10718    10730      +12     
+ Misses       5781     5773       -8     
+ Partials      550      546       -4     
Impacted Files Coverage Δ
internal/storagenode/logstream/executor.go 80.16% <0.00%> (-0.64%) ⬇️
internal/metarepos/storage.go 81.37% <0.00%> (+0.23%) ⬆️
internal/metarepos/report_collector.go 78.67% <0.00%> (+1.07%) ⬆️
...metarepos/dummy_storagenode_client_factory_impl.go 63.88% <0.00%> (+1.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


A large amount of empty commit contexts not only causes too slow recovery of
log streams but also takes a quite large disk space. To solve these problems,
this RFC proposes to store only the latest non-empty commit context rather
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need latest commit context & latest non-empty commit context both.
Latest commit context is used for valid report version to trim commit result in metadata repository

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. I'll fix it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hungryjang
Modified the draft to store the latest commit context regardless of emptiness.

@ijsong ijsong requested a review from hungryjang September 19, 2022 11:07
@ijsong
Copy link
Member Author

ijsong commented Sep 20, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants