-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies babel 7 #151
Conversation
…al thinking and checking what we actually need
Conflicts: yarn.lock
…hanged the lock file
example/package.json
Outdated
@@ -14,11 +14,12 @@ | |||
"npm-run-all": "^4.1.3" | |||
}, | |||
"dependencies": { | |||
"@babel/runtime": "^7.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this dependency be part of the library?
remove this depedency
as discussed: let's test these changes (both development as deployment) with some real world codebases before merging |
Take a look at: https://babeljs.io/docs/en/babel-plugin-proposal-decorators#decoratorsbeforeexport previously we had decorators before exports, but now it defaults to exports before decorators. Here's a discussion about this: tc39/proposal-decorators#69. I don't have a strong opinion about the issue, but it would be an easier transition if we stick to the old way. |
The setting is set to classic right? As far as I can tell classic is 'before export' anyway. |
1 similar comment
The setting is set to classic right? As far as I can tell classic is 'before export' anyway. |
There appear to be some changes regarding to css-modules values variables. Previously the |
|
It should still work when I look at the source code: https://github.com/css-modules/css-modules-loader-core/blob/master/src/index.js |
I think the problem is caused by having both postcss 6 and 7... Does the postcss nightmare ever stop? |
Ok, so the problem is nasty. We waited quite some time for cssnano to move to postcss 6. When it did (as version 4 was released) they quite quickly moved to postcss 7. A lot of the 4.0 issues have been fixed later (4.1.x), part of the release that contained these fixes was the move to postcss 7. Now postcss-modules or actually css-modules-loader-core (and it's dependencies) are still stuck on postcss 6. It seems however that this project is problematic: css-modules/css-modules-loader-core#174 Another one keeping postcss 6 is cssnext: Deprecating cssnext. I am not seeing a clear way out. When I push away the depression that creeps up and look at the related community from a non-judging / observational standpoint it seems this is not the right technology to be using. I'm sure we are not alone in this struggle, but we should be looking for one of the following:
|
There is some movement on the css module issues |
I've been working on a higgins+kaliberjs project while depending on this branch without any issues 👍 |
It seems there is a solution available for css modules. The webpack css loader plugin solves it by working around the This should also simplify our css loader plugin. |
Support https://github.com/css-modules/postcss-modules-extract-imports is tricky, so we won't add it |
The problem of this branch is that it introduces 2 versions of the postcss library. I started working on a solution (going without the unsupported css modules plugin) in the A shortterm alternative would be to update non-css related dependencies. |
Closed in favor of #159 |
Also updated some other dependencies.