Dependency updates #159
Dependency updates #159
Conversation
…al thinking and checking what we actually need
Conflicts: yarn.lock
…hanged the lock file
Conflicts: library/package.json yarn.lock
Conflicts: yarn.lock
example/package.json
Outdated
| "gsap": "^2.0.1", | ||
| "firebase-admin": "^7.0.0", | ||
| "gsap": "^2.0.2", | ||
| "icss-utils": "^4.0.0", |
There was a problem hiding this comment.
dependency should not be here
| const { minifyOnly = false, globalScopeBehaviour = false } = loaderOptions | ||
|
|
||
| return [ | ||
| // these plugis need to run on each file individual file | ||
| // look at the source of postcss-modules to see that it effectively runs all modules twice | ||
| !minifyOnly && require('../postcss-plugins/postcss-plugin-composition')([ |
There was a problem hiding this comment.
We can remove this plugin
Conflicts: library/package.json
|
repeatedly imported files (like |
|
production builds are building and running server-side without errors, though on the client there's an error: TypeError: Cannot set property 'lastEffect' of null |
That is already happening |
|
Anoying thing for development: These blocks are copied in the end result. The variables were previously replaced preventing the same behavior. |
This should be solved now (with Terser instead of Uglify) |
|
The |
|
|
||
| const isProduction = process.env.NODE_ENV === 'production' | ||
|
|
||
| function createPlugins(loaderOptions, { onExport, resolve, processUrl }) { | ||
| function createPlugins(loaderOptions, { resolve, processUrl }) { | ||
| const { minifyOnly = false, globalScopeBehaviour = false } = loaderOptions | ||
|
|
||
| return [ |
There was a problem hiding this comment.
If we have no plugins to run, we can just skip executing postcss
|
|
Updated dependencies.
As a result of changes in the Javascript world we had to ditch the 'postcss-modules' plugin and replace it with custom code. We also needed to replace 'postcss-next' with 'postcss-preset-env'.
More details in #151