Skip to content

Commit

Permalink
fix(FEC-141472): pass new prop to overlay (#136)
Browse files Browse the repository at this point in the history
pass new prop to `Overlay` component in `welcomeScreen` component - `dontCheckOverlayPortal`, which tells `Overlay` component to not check `overlayPortal` when removing `overlay-active` class, since it is being rendered outside of overlayPortal area.

**NOTE:** left a TODO note to check why the `Overlay` is not being rendered under `OverlayPortal`, as we usually do.

Resolves [FEC-14172](https://kaltura.atlassian.net/browse/FEC-14172)
related pr: kaltura/playkit-js-ui#950

[FEC-14172]: https://kaltura.atlassian.net/browse/FEC-14172?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
  • Loading branch information
lianbenjamin authored Sep 29, 2024
1 parent cb6b993 commit 0943acc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/components/welcome-screen/welcome-screen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ export const WelcomeScreen = withText(translates)(
),
[]
);
return onClose ? <Overlay open permanent children={renderWelcomeScreen} /> : renderWelcomeScreen;
// TODO: check why Overlay component is not being rendered under OverlayPortal component
return onClose ? <Overlay open permanent children={renderWelcomeScreen} dontCheckOverlayPortal /> : renderWelcomeScreen;
}
);

0 comments on commit 0943acc

Please sign in to comment.