fix(FEC-14172): overlay-active is not removed from player #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SivanA-Kaltura
approved these changes
Sep 29, 2024
lianbenjamin
added a commit
to kaltura/playkit-js-ivq
that referenced
this pull request
Sep 29, 2024
pass new prop to `Overlay` component in `welcomeScreen` component - `dontCheckOverlayPortal`, which tells `Overlay` component to not check `overlayPortal` when removing `overlay-active` class, since it is being rendered outside of overlayPortal area. **NOTE:** left a TODO note to check why the `Overlay` is not being rendered under `OverlayPortal`, as we usually do. Resolves [FEC-14172](https://kaltura.atlassian.net/browse/FEC-14172) related pr: kaltura/playkit-js-ui#950 [FEC-14172]: https://kaltura.atlassian.net/browse/FEC-14172?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
bugfix
Issue:
overlay-activeclass is not being removed from the player, which prevents any user interaction with the player.in this specific case,
welcomeScreenof quiz is anOverlaycomponent but is not rendered underOverlayPortal- which breaks the current condition to remove theoverlay-activeclass.Fix:
add a new prop -
dontCheckOverlayPortal, which indicates whetherOverlayshould go through theOverlayPortalcondition, or simply removeoverlay-activeclass unconditionally.Resolves FEC-14172
related pr: kaltura/playkit-js-ivq#136