VolumeGet implementation for VMware FCD (#339)

* VolumeGet implementation

* Set fields to default values

* Update the doc string

* Fix the import order

* Add error check

* Address review comments

pkg/blockstorage/vmware/conversion.go

@@ -0,0 +1,37 @@
+package vmware
+
+import (
+	"github.com/vmware/govmomi/vim25/types"
+
+	"github.com/kanisterio/kanister/pkg/blockstorage"
+)
+
+func convertFromObjectToVolume(vso *types.VStorageObject) *blockstorage.Volume {
+	return &blockstorage.Volume{
+		Type:         blockstorage.TypeFCD,
+		ID:           vso.Config.Id.Id,
+		CreationTime: blockstorage.TimeStamp(vso.Config.CreateTime),
+		Size:         vso.Config.CapacityInMB / 1024,
+		Az:           "",
+		Iops:         0,
+		Encrypted:    false,
+		VolumeType:   "",
+		Tags:         blockstorage.VolumeTags{},
+		Attributes:   map[string]string{},
+	}
+}
+
+// vimID wraps ID string with vim25.ID struct.
+func vimID(id string) types.ID {
+	return types.ID{
+		Id: id,
+	}
+}
+
+func convertKeyValueToTags(kvs []types.KeyValue) []*blockstorage.KeyValue {
+	tags := make(map[string]string)
+	for _, kv := range kvs {
+		tags[kv.Key] = kv.Value
+	}
+	return blockstorage.MapToKeyValue(tags)
+}

pkg/blockstorage/vmware/vmware.go

@@ -72,7 +72,17 @@ func (p *fcdProvider) VolumeDelete(ctx context.Context, volume *blockstorage.Vol
 }
 
 func (p *fcdProvider) VolumeGet(ctx context.Context, id string, zone string) (*blockstorage.Volume, error) {
-	return nil, errors.New("Not implemented")
+	obj, err := p.gom.Retrieve(ctx, vimID(id))
+	if err != nil {
+		return nil, errors.Wrap(err, "Failed to query the disk")
+	}
+	kvs, err := p.gom.RetrieveMetadata(ctx, vimID(id), nil, "")
+	if err != nil {
+		return nil, errors.Wrap(err, "Failed to get volume metadata")
+	}
+	vol := convertFromObjectToVolume(obj)
+	vol.Tags = convertKeyValueToTags(kvs)
+	return vol, nil
 }
 
 func (p *fcdProvider) SnapshotCopy(ctx context.Context, from blockstorage.Snapshot, to blockstorage.Snapshot) (*blockstorage.Snapshot, error) {