Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumeGet implementation for VMware FCD #339

Merged
merged 7 commits into from
Oct 9, 2019
Merged

Conversation

hakanmemisoglu
Copy link
Contributor

Change Overview

VolumeGet implementation for FCD.

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trivial/Minor
  • Bugfix
  • Feature
  • Documentation

pkg/blockstorage/vmware/vmware.go Outdated Show resolved Hide resolved
pkg/blockstorage/vmware/conversion.go Show resolved Hide resolved
@tdmanv
Copy link
Contributor

tdmanv commented Oct 9, 2019

I added the DNM tag incase you wanted to address the feedback first

@mergify mergify bot merged commit 3baeb82 into master Oct 9, 2019
@mergify mergify bot deleted the vmware-fcd-vol-get branch October 9, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants