Skip to content

Commit

Permalink
Rename gomod to go-mod-tidy in makefile targets (#2103)
Browse files Browse the repository at this point in the history
* Rename `gomod` to `gomodtidy` in makefile targets

We had two targets in our makefile one `gomod` and other `go-mod-download`.
By just reading `gomod` it was not clear if it's just running `go mod tidy`
or `go mod download` as well.
This commit makes that explicit by renaming gomod to gomodtidy.

* Rename makefile target `gomodtidy` to `go-mod-tidy`

* Remove unnecessary code

---------

Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
  • Loading branch information
viveksinghggits and pavannd1 authored Jun 13, 2023
1 parent 0b3f846 commit 884b8cb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- run: make gomod
- run: make go-mod-tidy
- run: make go-mod-download
- run: tar -cvf ./src.tar.gz ./ # preserve file permissions
- uses: actions/upload-artifact@v3
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,8 @@ stop-kind:
check:
@./build/check.sh

gomod:
@$(MAKE) run CMD='-c "./build/gomod.sh"'
go-mod-tidy:
@$(MAKE) run CMD='-c "./build/gomodtidy.sh"'


install-crds: ## Install CRDs into the K8s cluster specified in ~/.kube/config.
Expand Down
File renamed without changes.

0 comments on commit 884b8cb

Please sign in to comment.