Rename gomod to go-mod-tidy in makefile targets
#2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had two targets in our makefile one `gomod` and other `go-mod-download`. By just reading `gomod` it was not clear if it's just running `go mod tidy` or `go mod download` as well. This commit makes that explicit by renaming gomod to gomodtidy.
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
PrasadG193
approved these changes
Jun 13, 2023
viveksinghggits
force-pushed
the
rename-mod-modtidy-makefile
branch
from
e405f2a
to
f9cf65a
Compare
pavannd1
changed the title
gomod to gomodtidy in makefile targetsgomod to go-mod-tidy in makefile targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
We had two targets in our makefile one
gomodand othergo-mod-download. By just readinggomodit was not clear if it's just runninggo mod tidyorgo mod downloadas well.This commit makes that explicit by renaming gomod to gomodtidy.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan