Copy volumeSnapshotClass parameters when cloning #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Nov 2, 2021
| }, | ||
| } | ||
| } | ||
|
|
||
| func Mss2msi(in map[string]string) map[string]interface{} { |
There was a problem hiding this comment.
Can you please add comment to the function? It will help understand its purpose.
There was a problem hiding this comment.
Added a comment to clarify
| @@ -63,7 +63,7 @@ func cloneSnapshotClass(ctx context.Context, dynCli dynamic.Interface, snapClass | |||
| for _, key := range excludeAnnotations { | |||
| delete(existingAnnotations, key) | |||
| } | |||
| usNew := UnstructuredVolumeSnapshotClass(snapClassGVR, targetClassName, sourceSnapClass.Driver, newDeletionPolicy) | |||
| usNew := UnstructuredVolumeSnapshotClass(snapClassGVR, targetClassName, sourceSnapClass.Driver, newDeletionPolicy, sourceSnapClass.Parameters) | |||
There was a problem hiding this comment.
Hi @bathina2,
By introducing this argument it looks like we are assuming params field will always be there in the VolumeSnapshotClass. But I have seen some examples where params field is not present in the VoluemSnapshotClass resoruce, and because of that when we try to create the copied VolumeSnapshotClass with nil as parameter value VolumeSnapshotClass Creation fails with below error
"k10-clone-csi-hostpath-snapclass" is invalid: parameters: Invalid value: "null": parameters in body must be of type object: "null"
I was thinking we shouldn't pass the parameters field if the values is nil.
viveksinghggits
added a commit
that referenced
this pull request
Nov 19, 2021
While cloning `VolumeSnapshotClass`, as part of #1128 we started passing params. But we should not pass params if the values is `nil`, because in that case creation `VolumeSnapshotClass` fails with `nil` not allowed.
viveksinghggits
added a commit
that referenced
this pull request
Nov 19, 2021
While cloning `VolumeSnapshotClass`, as part of #1128 we started passing params. But we should not pass params if the values is `nil`, because in that case creation `VolumeSnapshotClass` fails with `nil` not allowed.
2 tasks
mergify bot
added a commit
that referenced
this pull request
Nov 19, 2021
…class (#1145) * Don't use params field while cloning volumesnapshotclass While cloning `VolumeSnapshotClass`, as part of #1128 we started passing params. But we should not pass params if the values is `nil`, because in that case creation `VolumeSnapshotClass` fails with `nil` not allowed. * Refactor, address review comments Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Copy parameters when cloning.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan