Don't use params field, if they are nil, while cloning volumesnapshotclass #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While cloning `VolumeSnapshotClass`, as part of #1128 we started passing params. But we should not pass params if the values is `nil`, because in that case creation `VolumeSnapshotClass` fails with `nil` not allowed.
onkarbhat
requested changes
Nov 19, 2021
bathina2
approved these changes
Nov 19, 2021
|
@viveksinghggits thanks for catching this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
While cloning
VolumeSnapshotClass, as part of #1128we started passing params. But we should not pass params if the values
is
nil, because in that case creationVolumeSnapshotClassfails withnilnot allowed.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Updated *** with kanister commit id and then updated the image in the env where we have been facing problem to make sure things have been resolved.