Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Kanister function to restore CSI VolumeSnapshot #1166

Merged
merged 47 commits into from
Jan 17, 2022
Merged

Adding a Kanister function to restore CSI VolumeSnapshot #1166

merged 47 commits into from
Jan 17, 2022

Conversation

shlokc9
Copy link
Contributor

@shlokc9 shlokc9 commented Dec 29, 2021 •
edited

Change Overview

This PR consists of a new Kanister function to restore CSI VolumeSnapshot along with it's documentation

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@shlokc9 shlokc9 changed the title Adding a Kanister function to restore CSI VolumeSnapshot [WIP] Adding a Kanister function to restore CSI VolumeSnapshot Dec 29, 2021
pavannd1
pavannd1 reviewed Dec 29, 2021
View reviewed changes
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
@shlokc9 shlokc9 marked this pull request as ready for review December 31, 2021 09:09
@shlokc9 shlokc9 changed the title [WIP] Adding a Kanister function to restore CSI VolumeSnapshot Adding a Kanister function to restore CSI VolumeSnapshot Dec 31, 2021
@shlokc9 shlokc9 mentioned this pull request Jan 5, 2022
Merged
10 tasks
PrasadG193
PrasadG193 reviewed Jan 6, 2022
View reviewed changes
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Show resolved Hide resolved
pavannd1
pavannd1 reviewed Jan 12, 2022
View reviewed changes
pkg/function/restore_csi_snapshot_test.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
pavannd1
pavannd1 reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized a few things while going through the changes again. You can address the create snapshot changes suggested separately.

pkg/function/restore_csi_snapshot_test.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot_test.go Outdated Show resolved Hide resolved
pkg/function/restore_csi_snapshot.go Outdated Show resolved Hide resolved
@shlokc9 shlokc9 mentioned this pull request Jan 13, 2022
Closed
10 tasks
pavannd1
pavannd1 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shlokc9 shlokc9 added the kueue label Jan 17, 2022
@mergify mergify bot merged commit fe499ac into master Jan 17, 2022
@mergify mergify bot deleted the func-restore-csi-snapshot branch January 17, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shlokc9 @pavannd1 @PrasadG193 @viveksinghggits