Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Kanister function to delete CSI VolumeSnapshot #1172

Merged
merged 79 commits into from
Jan 19, 2022
Merged

Adding a Kanister function to delete CSI VolumeSnapshot #1172

merged 79 commits into from
Jan 19, 2022

Conversation

shlokc9
Copy link
Contributor

@shlokc9 shlokc9 commented Jan 5, 2022 •
edited

Change Overview

This PR consist of a new Kanister function to delete CSI VolumeSnapshot along with it's documentation

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@shlokc9
Added new function RestoreCSISnapshot
f6aa6a8
@shlokc9
reviewer comments
376e7a3
@shlokc9
Fixed failed to render outputartifact template 'snapshotInfo' issue
d4731e5
@shlokc9
Updated const comments
5d7d94a
@shlokc9
Updated the return obj for the function
dba3c4d
@shlokc9
Added documentation for RestoreCSISnapshot function
9d59a1b
@shlokc9
Merge branch 'master' of https://github.com/kanisterio/kanister into …
c845d60 
…func-restore-csi-snapshot
@shlokc9
Added test suite for RestoreCSISnapshot func
52c74f2
@shlokc9
gofmt update
cda73ff
@shlokc9
Reviewer comments
f42508f
@shlokc9
Updated the testcase for RestoreCSISnapshot function
09311f5
@shlokc9
Updated the createPVC method in testcase
439ff57
@shlokc9
Fixed RBAC YAML
427ad77
@shlokc9
Added the DeleteCSISnapshot function
f296e8a
@shlokc9
Added RBAC updates
9bb731d
@shlokc9
Added testcase for DeleteCSISnapshot function
1c87146
@shlokc9
gofmt fix
567072e
@shlokc9
Added documentation for DeleteCSISnapshot function
5a73ed6
@shlokc9 shlokc9 marked this pull request as ready for review January 5, 2022 09:46
@shlokc9
Copy link
Contributor Author

shlokc9 commented Jan 5, 2022 •
edited

The unit test in this PR depends on methods from restore PR. Following PRs need to be merged first.

#1163
#1166

@shlokc9 shlokc9 requested a review from pavannd1 January 14, 2022 05:48
@shlokc9 shlokc9 mentioned this pull request Jan 14, 2022
Closed
10 tasks
@shlokc9
Copy link
Contributor Author

shlokc9 commented Jan 17, 2022

@pavannd1 @viveksinghggits @PrasadG193 Need atleast one approval here

@shlokc9 shlokc9 added the kueue label Jan 18, 2022
@shlokc9 shlokc9 removed the kueue label Jan 18, 2022
@shlokc9 shlokc9 added kueue and removed kueue labels Jan 19, 2022
@shlokc9 shlokc9 added the kueue label Jan 19, 2022
@mergify mergify bot merged commit cdc321c into master Jan 19, 2022
@mergify mergify bot deleted the func-delete-csi-snapshot branch January 19, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@pavannd1 pavannd1 pavannd1 approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shlokc9 @viveksinghggits @pavannd1