-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support blueprint resource for validate sub command to kanctl
#1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavannd1
reviewed
Jan 19, 2022
Call with supported version of kanister functions
Call with unsupported version of kanister functions
|
pavannd1
reviewed
Jan 20, 2022
pavannd1
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions
Merge after addressing
viveksinghggits
added a commit
that referenced
this pull request
Jan 27, 2022
This commit adds go code to add a webhook server that does basics check on the bluerint resources when they are created. We are doing the only checks that we introduced as part of #1187
viveksinghggits
added a commit
that referenced
this pull request
Feb 1, 2022
This commit adds go code to add a webhook server that does basics check on the bluerint resources when they are created. We are doing the only checks that we introduced as part of #1187
viveksinghggits
added a commit
that referenced
this pull request
Feb 4, 2022
This commit adds go code to add a webhook server that does basics check on the bluerint resources when they are created. We are doing the only checks that we introduced as part of #1187
viveksinghggits
added a commit
that referenced
this pull request
Feb 8, 2022
This commit adds go code to add a webhook server that does basics check on the bluerint resources when they are created. We are doing the only checks that we introduced as part of #1187
mergify bot
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Add val webhook controller for blueprint resources This commit adds go code to add a webhook server that does basics check on the bluerint resources when they are created. We are doing the only checks that we introduced as part of #1187 * Update helm to create service and validating webhook configuration * Remove unnecesary code * Refactor error messages * Run webhook server only if webhook certs are mounted in the pod In the cases if we dont want to run the webhook server in kanister controller pod but just want to have the `healthz` endpoint and prom endpoint in that case if we don't mount the webhook certs we will just be running the standard http server and the webhook server. * Rebase with master, resolve conflict * Address review comments, minor refactor * Address review comments * Resolve conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
kanctl
command didn't support blueprint resource to get validated. This PR add support for blueprint resource askanctl validate
sub command.These are some of the validation that we are planning to achieve
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan