Add validating webhook controller for blueprint resource #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavannd1
reviewed
Feb 1, 2022
viveksinghggits
force-pushed
the
kan-val-wh
branch
2 times, most recently
from
69bcdb1
to
d458888
Compare
viveksinghggits
commented
Feb 1, 2022
pavannd1
reviewed
Feb 3, 2022
|
LGTM - minor comments |
viveksinghggits
force-pushed
the
kan-val-wh
branch
from
4a0283e
to
8cb4e4d
Compare
pavannd1
approved these changes
Feb 8, 2022
This commit adds go code to add a webhook server that does basics check on the bluerint resources when they are created. We are doing the only checks that we introduced as part of #1187
In the cases if we dont want to run the webhook server in kanister controller pod but just want to have the `healthz` endpoint and prom endpoint in that case if we don't mount the webhook certs we will just be running the standard http server and the webhook server.
viveksinghggits
force-pushed
the
kan-val-wh
branch
from
8cb4e4d
to
9f7721a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Add validaating webhook for the blueprint resources that is going to do some basic check even before the blueprint is actually created in the cluster.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Deploy kanister from local repo and make sure invalid blueprints are not created
Install kanister
0.72.0and upgrade that to new changes make sure things are working.