Add a check for permission to createVolume for EBS and creds validation for aws #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leuyentran
commented
Mar 29, 2022
| @@ -148,3 +147,21 @@ func GetConfig(ctx context.Context, config map[string]string) (awsConfig *aws.Co | |||
| } | |||
| return &aws.Config{Credentials: creds}, region, nil | |||
| } | |||
|
|
|||
| func IsAwsCredsValid(ctx context.Context, config map[string]string) (bool, error) { | |||
There was a problem hiding this comment.
It is a conscious decision here to pass config map[string]string as input , as opposed to *aws.Config. This design is to minimize kanister calls on caller side. All that is needed to validate creds is the the creds itself, without having to call another kanister func beforehand (such as GetConfig())
leuyentran
changed the title
bathina2
approved these changes
Mar 30, 2022
mergify
bot
deleted the
add-permission-check-func-ebs-and-creds-validation-aws
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR:
CheckVolumeCreateto check EC2 permission to perform VolumeCreate actionIsAwsCredsValidto check credibility of AWS credsPull request type
Please check the type of change your PR introduces:
Issues
Test Plan