-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check for permission to createVolume for EBS and creds validation for aws #1339
Merged
mergify
merged 3 commits into
master
from
add-permission-check-func-ebs-and-creds-validation-aws
Mar 30, 2022
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
// Copyright 2022 The Kanister Authors. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package aws | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
"gopkg.in/check.v1" | ||
|
||
envconfig "github.com/kanisterio/kanister/pkg/config" | ||
) | ||
|
||
// Hook up gocheck into the "go test" runner. | ||
func Test(t *testing.T) { check.TestingT(t) } | ||
|
||
type AWSSuite struct{} | ||
|
||
var _ = check.Suite(&AWSSuite{}) | ||
|
||
func (s AWSSuite) TestValidCreds(c *check.C) { | ||
ctx := context.Background() | ||
config := map[string]string{} | ||
|
||
config[AccessKeyID] = envconfig.GetEnvOrSkip(c, AccessKeyID) | ||
config[SecretAccessKey] = envconfig.GetEnvOrSkip(c, SecretAccessKey) | ||
config[ConfigRegion] = "us-west-2" | ||
|
||
res, err := IsAwsCredsValid(ctx, config) | ||
c.Assert(err, check.IsNil) | ||
c.Assert(res, check.Equals, true) | ||
|
||
config[AccessKeyID] = "fake-access-id" | ||
res, err = IsAwsCredsValid(ctx, config) | ||
c.Assert(err, check.NotNil) | ||
c.Assert(res, check.Equals, false) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a conscious decision here to pass
config map[string]string
as input , as opposed to*aws.Config
. This design is to minimize kanister calls on caller side. All that is needed to validate creds is the the creds itself, without having to call another kanister func beforehand (such asGetConfig()
)