-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BUILD.md Development Guide #1347
Conversation
Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
``` | ||
|
||
The following targets can be used to lint, test and build the Kanister | ||
controller: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also add steps to build kanctl
and kando
binaries. If not separately there should be a target that just builds all the binaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be done in a follow up PR 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated build/build.sh
in #1355 to build kanctl
and kando
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
``` | ||
|
||
The following targets can be used to lint, test and build the Kanister | ||
controller: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be done in a follow up PR 👍🏼
Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
Change Overview
This PR adds the BUILD.md development guide, with instructions on how to test, build and package Kanister locally. It also adds a new
check
target to the Makefile to do some preliminary dev tools check.Pull request type
Please check the type of change your PR introduces:
Issues
make check
command to check if dependencies needed to build the project are installed. #1266