-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH Actions CI Workflow #1355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like we discussed we should let it run parallel to travis for sometime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Question on the images being built - will we have both Travis and GHA trying to build and tag the same docker images?
@pavannd1 yes, but it should be idempotent. |
ba4fa2b
to
4b30ea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎊 🚀 🥳
🥇Thanks for doing this.
In future iterations it'd be good to explore how to break down the jobs into smaller pieces, and also increase the level of parallelism. Also, it'd be good to figure out how long does it take to pass artifacts between jobs (accounting for both upload & download) and see whether or not that provides benefits vs. for example, re-running some steps.
Another thing to consider later is whether it makes sense to have the release job in a separate workflow.
It'd make sense to merge it then and have it be a "not required" check. @viveksinghggits Do you want to kueue it? |
Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
fc3e923
to
0eb6259
Compare
Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
Looks like mergify requires addition |
0eb6259
to
e46938b
Compare
Change Overview
This PR re-enables the GH Actions CI workflow. I would like to let it run in parallel to the current CI setup to compare the two CI solutions in terms of their speed, efficiency, responsiveness, flakiness and cost.
All the existing Travis CI jobs and stages have been added to the GH Actions
main.yaml
workflow. A completed successful CI run looks like this:See https://github.com/kanisterio/kanister/actions/runs/2097423926.
Some highlights include:
test
,integration-test
, andhelm-test
suitescontroller
,kanctl
andkando
binariesrelease
job only when there is a new merge intomaster
or a new tagmake release-snapshot
target)Pull request type
Please check the type of change your PR introduces:
Issues