Change format.Writer to not format phase output log lines #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When kube.ExecOutput() writes the remote stdout/stderr outputs to the user-provided writers, it calls format.Writer() to format the outputs to the Kanister-log format. This causes the "phase output" to be prepended with log metadata such as log timestamp, caller function etc. A previous attempt to expand the output.Parse() function regex to handle these log metadata prefixes has caused some downstream failures. This fix reverts to the previous implementation of output.Parse(). It also updates the format.Writer() to not format any "phase output". Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
pavannd1
approved these changes
May 6, 2022
akankshakumari393
pushed a commit
that referenced
this pull request
May 9, 2022
When kube.ExecOutput() writes the remote stdout/stderr outputs to the user-provided writers, it calls format.Writer() to format the outputs to the Kanister-log format. This causes the "phase output" to be prepended with log metadata such as log timestamp, caller function etc. A previous attempt to expand the output.Parse() function regex to handle these log metadata prefixes has caused some downstream failures. This fix reverts to the previous implementation of output.Parse(). It also updates the format.Writer() to not format any "phase output". Signed-off-by: Ivan Sim <ivan.sim@kasten.io> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR fixes a string-matching bug that caused phase outputs to fail to
be marshalled in some cases.
When kube.ExecOutput() writes the remote stdout/stderr outputs to the
user-provided writers, it calls format.Writer() to format the outputs
to the Kanister-log format. This causes the "phase output" to be
prepended with log metadata such as log timestamp, caller function etc.
A previous attempt to expand the output.Parse() function regex to handle
these log metadata prefixes has caused some downstream failures.
This fix reverts to the previous implementation of output.Parse(). It
also updates the format.Writer() to not format any "phase output".
Pull request type
Please check the type of change your PR introduces:
Test Plan