Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change format.Writer to not format phase output log lines #1431

Merged
merged 2 commits into from
May 6, 2022
Merged

Change format.Writer to not format phase output log lines #1431

merged 2 commits into from
May 6, 2022

Commits on May 6, 2022

  1. Change format.Writer to not format phase output log lines 

    When kube.ExecOutput() writes the remote stdout/stderr outputs to the
user-provided writers, it calls format.Writer() to format the outputs
to the Kanister-log format. This causes the "phase output" to be
prepended with log metadata such as log timestamp, caller function etc.

A previous attempt to expand the output.Parse() function regex to handle
these log metadata prefixes has caused some downstream failures.

This fix reverts to the previous implementation of output.Parse(). It
also updates the format.Writer() to not format any "phase output".

Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
    @ihcsim
    ihcsim committed May 6, 2022
    Configuration menu
    Copy the full SHA
    c73560f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-output-parse

    @mergify
    mergify[bot] authored May 6, 2022
    Configuration menu
    Copy the full SHA
    1f2cb3a View commit details
    Browse the repository at this point in the history