[Kopia wrappers - C] Separate out kopia commands from a single file #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
shlokc9
force-pushed
the
kopia-wrappers-c
branch
from
3bb4c56
to
7061c89
Compare
10 tasks
| @@ -1,486 +0,0 @@ | |||
| // Copyright 2022 The Kanister Authors. | |||
There was a problem hiding this comment.
Since we are introducing this file in #1526 and removing it here, would it make more sense to merge these two PRs and then it would be easier to review only one version of these changes?
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Add kopia wrappers * Add logsafe module * Modify utils package * Add errors package * Add apis/config package * Refactor kopia wrapper module * Remove downstream user reference * Address reviewer comments * Separate constant files in Kopia package * Add command logsafe * Add utility functions * Created sub-packages for repository and snapshot wrapper methods * Add license info in constant files * Move helper functions out of the kopia.go file * Rename kopia.go to commands.go * Rename OpenRepository, DeleteSnapshot and reportSnapshotStatus methods * Convert constants and functions from local to global * Fix constant in pkg/kopia/snapshot/stream.go * Fix const description in pkg/kopia/utils.go * Added some more utils functions * Update maintenance info command and add maintenance utils * Add Client keyword in constants and rename kankopia import alias in pkg/stream/stream.go * Rename kopiaArgs to commonArgs * Resolve cyclic import statements * Rename cmd package to command * Resolve cyclic commit * Refactor separate log_output_utils.go * Fix command utility import * Remove nested loop * Change log level to Debug * [Kopia wrappers - C] Separate out kopia commands from a single file (#1552) * Separate out kopia commands from a single file * Combine wrapper functions * Fix policyChanges in PolicySetGlobal command wrapper * Move command wrapper arguments * Add CommandArgs struct to pass args to command wrappers * Convert local arguments to exportable arguments * Change log level to Debug * Remove unused const * Fix for make gomod in CI * Move RegEx as a const * Rename pkg/kopia/command/kopia.go to pkg/kopia/command/common.go * Rename log_output_utils.go to parse_command_output.go and Move output parsing functions from helpers.go to parse_command_output.go * Group 'kopia blob' commands in single file * Group 'kopia maintenance' commands in single file * Group 'kopia server' commands in single file * Move parent command functions closer in pkg/kopia/command/server.go * Group 'kopia snapshot' commands in single file * Group 'kopia snapshot' commands in single file * rename commandArgs in all commands * Simplify nil check in if statements * Fix golang issues * Fix golint issues * Add recent changes to snapshot create stats parsed from the 'kopia snapshot create' command * Fix go.mod issue in golint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR separates each kopia command into a separate file
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan