Update kanister build v0.0.20 #1676

bathina2 · 2022-10-13T21:00:45Z

Change Overview

update kanister build to ~~v0.0.19~~ v0.0.20. This updates to go 1.19. It also updates the linter and as leads to several changes across all packages.

Pull request type

Please check the type of change your PR introduces:

Issues

fixes #issue-number

Test Plan

💪 Manual
⚡ Unit test
💚 E2E

github-actions · 2022-10-13T21:00:58Z

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

miquella · 2022-10-14T19:59:30Z

pkg/blockstorage/ibm/ibmcloud.go

@@ -124,7 +124,7 @@ func (s *ibmCloud) volumeParse(ctx context.Context, vol *ibmprov.Volume) (*block
 	}
 	attribs[LunIDAttName] = vol.LunID

-	if len(vol.IscsiTargetIPAddresses) < 0 {
+	if len(vol.IscsiTargetIPAddresses) == 0 {


This seems like a bug fix that shouldn't be hidden in a tooling bump commit. Can we split this out into a separate PR, please?

miquella · 2022-10-14T20:00:07Z

pkg/blockstorage/vmware/vmware.go

@@ -791,6 +791,7 @@ func (ge govmomiError) Format() string {
 	return fmt.Sprintf("[%s]", strings.Join(msgs, "; "))
 }

+// nolint:gocognit


"Directive" type comments shouldn't have a space after the //.

Suggested change

// nolint:gocognit

//nolint:gocognit

heh, theres a bunch of places where this needs to be fixed

miquella · 2022-10-14T20:00:50Z

pkg/envdir/envdir.go

+	fis := make([]fs.FileInfo, 0, len(entries))
+	for _, entry := range entries {
+		fi, err := entry.Info()
+		if err != nil {
+			return nil, errors.Wrap(err, "failed to read info from entry:"+entry.Name())
+		}
+		fis = append(fis, fi)
+	}


Can you explain why we're making this change? I don't quite understand.

This deprecation note explains it - https://pkg.go.dev/io/ioutil#ReadDir

However I blindly converted. After looking at the code more, I can probably use the response from ReadDir directly.

miquella · 2022-10-14T20:20:07Z

pkg/kube/pod.go

+//  1. if PVC is present then check the status of PVC
+//     1.1 if PVC is pending then check if the PV status is VolumeFailed return error if so. if not then wait for timeout.
+//  2. if PVC not present then wait for timeout


This reformatting is showing that Go doesn't recognize the nested "1.1" item (Go doesn't support nested lists at all). The way this is formatted, it's actually treating it as a continuation of the 1. list item — "… the status of PVC 1.1 if PVC is …".

We should probably reformat this to not use a nested list (i.e. move "1.1" to be a top-level item in the list, renumbering the items or switching to an unordered list).

miquella · 2022-10-14T20:20:15Z

pkg/kube/pod.go

+//  1. if PVC is present then check the status of PVC
+//     1.1 if PVC is pending then check if the PV status is VolumeFailed return error if so. if not then wait for timeout.
+//  2. if PVC not present then wait for timeout


Ditto, as above.

julio-lopez · 2022-10-17T17:41:39Z

@bathina2 other than Mark's comments, LGTM.

julio-lopez

@miquella had additional comments. Please follow up in separate PRs.

miquella

LGTM, just a few tiny Go Doc Comment nits

miquella · 2022-10-17T20:36:51Z

pkg/kube/pod.go

+// - if PVC is present then check the status of PVC
+// - if PVC is pending then check if the PV status is VolumeFailed return error if so. if not then wait for timeout.
+// - if PVC not present then wait for timeout


tiny nit: Go Doc Comments says that bullet lists should be indented, so this should be:

Suggested change

// - if PVC is present then check the status of PVC

// - if PVC is pending then check if the PV status is VolumeFailed return error if so. if not then wait for timeout.

// - if PVC not present then wait for timeout

// - if PVC is present then check the status of PVC

// - if PVC is pending then check if the PV status is VolumeFailed return error if so. if not then wait for timeout.

// - if PVC not present then wait for timeout

miquella · 2022-10-17T20:37:45Z

pkg/kube/pod.go

+// - if PVC is present then check the status of PVC
+// - if PVC is pending then check if the PV status is VolumeFailed return error if so. if not then wait for timeout.
+// - if PVC not present then wait for timeout


ditto:

Suggested change

// - if PVC is present then check the status of PVC

// - if PVC is pending then check if the PV status is VolumeFailed return error if so. if not then wait for timeout.

// - if PVC not present then wait for timeout

// - if PVC is present then check the status of PVC

// - if PVC is pending then check if the PV status is VolumeFailed return error if so. if not then wait for timeout.

// - if PVC not present then wait for timeout

miquella · 2022-10-17T20:39:29Z

pkg/restic/restic.go

 // Verbosef("will delete %d packs and rewrite %d packs, this frees %s\n",
-//		len(removePacks), len(rewritePacks), formatBytes(uint64(removeBytes)))
+//
+//	len(removePacks), len(rewritePacks), formatBytes(uint64(removeBytes)))


tiny nit: this looks like it's supposed to be formatted:

Suggested change

// Verbosef("will delete %d packs and rewrite %d packs, this frees %s\n",

// len(removePacks), len(rewritePacks), formatBytes(uint64(removeBytes)))

//

// len(removePacks), len(rewritePacks), formatBytes(uint64(removeBytes)))

//

// Verbosef("will delete %d packs and rewrite %d packs, this frees %s\n",

// len(removePacks), len(rewritePacks), formatBytes(uint64(removeBytes)))

update makefile to use kanister build v0.0.19

f9a3193

infraq added this to In Progress in Kanister Oct 13, 2022

bathina2 requested review from viveksinghggits and julio-lopez October 13, 2022 21:01

julio-lopez approved these changes Oct 13, 2022

View reviewed changes

Kanister automation moved this from In Progress to Reviewer approved Oct 13, 2022

julio-lopez added the kueue label Oct 13, 2022

viveksinghggits approved these changes Oct 14, 2022

View reviewed changes

Fix linter issues

67178a1

bathina2 removed the kueue label Oct 14, 2022

bathina2 changed the title ~~update makefile to use kanister build v0.0.19~~ Update kanister build v0.0.20 Oct 14, 2022

bathina2 requested review from viveksinghggits, julio-lopez and miquella October 14, 2022 18:47

miquella reviewed Oct 14, 2022

View reviewed changes

bathina2 added 3 commits October 14, 2022 12:55

after marks review

b2e99c1

use ReadDir output directly

4b83f77

remove accidental error check

f32b7fe

gofmt fixes

a437329

julio-lopez approved these changes Oct 17, 2022

View reviewed changes

julio-lopez added the kueue label Oct 17, 2022

Merge branch 'master' into update_kanister_build_v0.0.19

a8b6866

miquella approved these changes Oct 17, 2022

View reviewed changes

mergify bot merged commit db036d5 into master Oct 17, 2022

Kanister automation moved this from Reviewer approved to Done Oct 17, 2022

mergify bot deleted the update_kanister_build_v0.0.19 branch October 17, 2022 20:52

bathina2 mentioned this pull request Oct 17, 2022

fix spacing #1687

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update kanister build v0.0.20 #1676

Update kanister build v0.0.20 #1676

bathina2 commented Oct 13, 2022 •

edited

Loading

github-actions bot commented Oct 13, 2022

miquella Oct 14, 2022

bathina2 Oct 14, 2022 •

edited

Loading

miquella Oct 14, 2022

bathina2 Oct 14, 2022

miquella Oct 14, 2022

bathina2 Oct 14, 2022

bathina2 Oct 14, 2022

miquella Oct 14, 2022

miquella Oct 14, 2022

julio-lopez commented Oct 17, 2022

julio-lopez left a comment

miquella left a comment

miquella Oct 17, 2022

miquella Oct 17, 2022

miquella Oct 17, 2022

Update kanister build v0.0.20 #1676

Update kanister build v0.0.20 #1676

Conversation

bathina2 commented Oct 13, 2022 • edited Loading

Change Overview

Pull request type

Issues

Test Plan

github-actions bot commented Oct 13, 2022

Choose a reason for hiding this comment

bathina2 Oct 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

julio-lopez commented Oct 17, 2022

julio-lopez left a comment

Choose a reason for hiding this comment

miquella left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bathina2 commented Oct 13, 2022 •

edited

Loading

bathina2 Oct 14, 2022 •

edited

Loading