Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where len is compared to less than 0 #1682

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Fix bug where len is compared to less than 0 #1682

merged 3 commits into from
Feb 16, 2023

Conversation

bathina2
Copy link
Contributor

@bathina2 bathina2 commented Oct 14, 2022 •
edited

Change Overview

len() will never equate to less than zero.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Oct 14, 2022
@bathina2 bathina2 mentioned this pull request Oct 14, 2022
Merged
10 tasks
PrasadG193
PrasadG193 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Jan 4, 2023
@PrasadG193
Copy link
Contributor

Hey @bathina2,
Thanks for fixing this. Could you please resolve the conflicts?

@bathina2
merge
88acc37 
Merge branch https://github.com/kanisterio/kanister into less_than_0_bugfix
@bathina2 bathina2 added the kueue label Feb 16, 2023
@mergify mergify bot merged commit 0db8d22 into master Feb 16, 2023
Kanister automation moved this from Reviewer approved to Done Feb 16, 2023
@mergify mergify bot deleted the less_than_0_bugfix branch February 16, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@miquella miquella Awaiting requested review from miquella

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Issue in IBM cloud where error is not returned if empty ISCSI targets
2 participants
@bathina2 @PrasadG193