Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BUILD.md with instructions to build and push controller images #1694

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

ihcsim
Copy link
Contributor

@ihcsim ihcsim commented Oct 19, 2022

Change Overview

Update BUILD.md with instructions to build and push controller images. (I forgot to check this in a while back.)

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Oct 19, 2022
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BUILD.md Outdated Show resolved Hide resolved
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Oct 25, 2022
@pavannd1 pavannd1 added the kueue label Oct 25, 2022
@mergify mergify bot merged commit a878179 into master Oct 25, 2022
Kanister automation moved this from Reviewer approved to Done Oct 25, 2022
@mergify mergify bot deleted the build-doc branch October 25, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Add Docker details in BUILD.md
4 participants